Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gomod for cherrypick #7032

Merged
merged 7 commits into from
Sep 19, 2024
Merged

chore: update gomod for cherrypick #7032

merged 7 commits into from
Sep 19, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Sep 17, 2024

Fixes #N/A

Description
Updating gomod for cherry pick for 1662

How was this change tested?
testing here

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner September 17, 2024 23:12
@njtran njtran requested a review from jigisha620 September 17, 2024 23:12
njtran
njtran commented Sep 17, 2024
View reviewed changes
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-900c8bbea460787edf5a1657c0a9c3b5229bedb0.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-900c8bbea460787edf5a1657c0a9c3b5229bedb0" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

rschalo
rschalo previously approved these changes Sep 17, 2024
View reviewed changes
@rschalo rschalo self-requested a review September 17, 2024 23:42
njtran
njtran commented Sep 18, 2024
View reviewed changes
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-eb53bcb7380a1514d91b794fd2d4403d4cd1201c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-eb53bcb7380a1514d91b794fd2d4403d4cd1201c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Sep 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10931998081

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 77.819%
Totals Coverage Status
Change from base Build 10909410812: 0.01%
Covered Lines: 5652
Relevant Lines: 7263
💛 - Coveralls

@njtran njtran merged commit 4cff8ec into aws:release-v0.36.x Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschalo rschalo rschalo approved these changes

@jigisha620 jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @rschalo